fix: don't use hardcoded support urls - WPB-24858#4594
Draft
johnxnguyen wants to merge 1 commit intorelease/cycle-4.16from
Draft
fix: don't use hardcoded support urls - WPB-24858#4594johnxnguyen wants to merge 1 commit intorelease/cycle-4.16from
johnxnguyen wants to merge 1 commit intorelease/cycle-4.16from
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue
The "learn more" link in the E2EE system message at the start of the conversation is hardcoded to a Wire support page. Instead it should be configurable. This PR moves the link to the
urls.jsonconfig file so it can be changed per build.Testing
Open the app, navigate to the start of a conversation and tap on the "learn more" link about E2EE. Assert it opens the correct link.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: